CLN: Add/refine type hints to some functions in core.dtypes.cast #33286
Conversation
- maybe_cast_result obj is now "Series" - Added type hint and assert to maybe_cast_to_extension_array - Added generic type to _GroupBy and GroupBy in core.groupby.groupby - Updated missed "try_cast" references to "maybe_cast"
| @@ -329,6 +333,8 @@ def maybe_cast_to_extension_array(cls, obj, dtype=None): | |||
| ExtensionArray or obj | |||
| """ | |||
| assert isinstance(cls, type), f"must pass a type: {cls}" | |||
| assertion_msg = f"must pass a subclass of ExtensionArray: {cls}" | |||
| assert issubclass(cls, ABCExtensionArray), assertion_msg | |||
There was a problem hiding this comment.
Is the assert here still necessary, or does the type hint now make this redundant?
There was a problem hiding this comment.
@simonjayhawkins Would like your thoughts on this.
There was a problem hiding this comment.
the type hint is sufficient for the static checking (so that mypy doesn't report any errors). For the assert, it depends on the desired runtime behaviour.
see #32302 (comment) |
|
thanks @rhshadrach very nice! |
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffSome cleanup resulting from PR #32894. In order to get SeriesGroupBy._transform_fast to realize self.obj is a Series, it seemed I needed to add a generic type to GroupBy and _GroupBy. I don't know if there is a better way to do this. Here, one cannot use FrameOrSeries as a Series may return a DataFrame and vice-versa, so I added _GroupByT.